-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): more vehicle repairs besides tires and solar panels require materials now #4293
feat(balance): more vehicle repairs besides tires and solar panels require materials now #4293
Conversation
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
…osvolt/Cataclysm-BN into vehicle-repair-material-need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have my blessing
been three days and no objection, looks like good to merge |
Purpose of change
This finally implements a lil something I had on the backburner for a while: making more vehicle repairs have a material cost associated with them. Reasoning being:
Describe the solution
vehicle_repair_electronics
, for general material cost of generic electronic vehiclepart repairs. Adds a component cost of 1 scrap metal and 3 copper wire (used in place ofsteel_tiny
to make it less metal-intensive for small parts).vehicle_repair_small_metal
addvehicle_repair_small_wood
meanwhile are workarounds for the inability to specify , used in the same wayplastics
andtire_repair
called for as a way to cite single components in a vehicle repair that only really seems to supportusing
.vehicle_repair_electronics
, also downgraded any uses ofwelding_standard
tosoldering_standard
. Bike alternators stay at merely using adhesive instead of welding or soldering.steel_tiny
to rebar and spring plates.vehicle_repair_electronics
andplastics
to repair entries for lead-acid batteries, and downgradedwelding_standard
tosoldering_standard
for them.steel_tiny
andwood_structural_small
to relevant quarterpanels and boards,fabric_standard
to cloth panels (also swapping use ofadhesive
forsewing_standard
). Simple sheet metal boards/panels meanwhile use 2vehicle_repair_small_metal
to make their material cost lower than most all-metal parts.adhesive
forsewing_standard
in the case of cloth baskets,vehicle_repair_small_metal
for the light baskets.steel_tiny
to combustion engines,steel_standard
and a bit more welding for turbine and steam engines.steel_tiny
for door repairs.steel_tiny
for most engineering part repairs, orvehicle_repair_small_metal
in the case of kickstands.steel_tiny
for most, just scrap for foldable light feames, aluminum for regular light frames,wood_structural_small
for wood frames, etc.vehicle_repair_electronics
for lighting vehicleparts, and swapping any cases ofwelding_standard
forsoldering_standard
instead.steel_tiny
to foot pedals and hand rims.plastics
to mirror repair. Picked that instead of adding glass shards since for now it still uses adhesive instead of soldering or welding.vehicle_repair_electronics
to all motor repairs.steel_tiny
for most standard rams,steel_standard
for composite rams,wood_structural_small
for wooden rams, and alloy sheets for alloy rams. Also fixed chitin not being repairable when chitin plates are.steel_tiny
to rotor repairs, additionally toning homemade gyro rotors down to usingadhesive
pluswood_structural_small
in place of welding since the rotors are made of wood.steel_tiny
for seat repairs, scrap in the case of saddles.steel_tiny
,plastics
, andwood_structural_small
for vehicle tank repairs.steel_tiny
plus copper wire (to not call for redundant scrap) for utility part repairs.steel_tiny
,wood_structural_small
,vehicle_repair_electronics
, scrap metal, splintered wood etc for unsorted parts in vehicle_parts.json. Also in the process fixed sails and handle paddles being 100% free to repair. I went ahead and added requirements to install/remove sails too, but kept hand paddles easy to put on and take off since logically the idea is they're just being slapped on top of the vehicle and declared a part. Also in the process downgraded vehicle controls, robot controls, and drive by wire controls from welding to soldering.Describe alternatives you've considered
Testing
So something delightfully fucking cursed I learned: vehicle repair interactions cannot actually use
using
andcomponents
at the same time without erroring and claiming that the latter counts as undefined JSON (when it treats it as defined if it's used WITHOUTusing
being in the same action). This is likely why we have cursed crafting requirements liketire_repair
being just single rubber chunks, because its only vanilla usage has it promptly paired with theadhesive
crafting requirement and therefore it has to be added byusing
instead ofcomponents
.Additional context
DDA if I recall has done a very limited take on this concept via welding repairs costing metal, but they also use it to force the player to use welding rods plus they basically only seem to have expanded it to metal repairs, other stuff like wood is still stiched back together with just glue.
Checklist